Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert every allOf tag to oneOf in OpenAPI schema #372

Closed
RichardBruskiewich opened this issue Sep 8, 2022 · 1 comment
Closed

Convert every allOf tag to oneOf in OpenAPI schema #372

RichardBruskiewich opened this issue Sep 8, 2022 · 1 comment
Milestone

Comments

@RichardBruskiewich
Copy link
Contributor

TRAPI 1.3 validation was problematic with jsonschema (inside the reasoner-validator) due to the use of allOf OpenAPI schema property alongside nullable: true.

Review of the definitions for allOf versus oneOf suggest this is a reasonable revision, given that logically, one cannot satisfy both a concrete non-null JSON data model and a null value, at the same time, but rather, choosing one or the other (i.e non-empty schema xor null, i.e. oneOf) is a more reasonable semantic expectation.

@edeutsch
Copy link
Collaborator

Addressed in #403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants