Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace fancybox library with Bootstrap modals #311

Open
laurenwalker opened this issue Oct 20, 2017 · 1 comment
Open

Replace fancybox library with Bootstrap modals #311

laurenwalker opened this issue Oct 20, 2017 · 1 comment
Assignees
@laurenwalker
Labels
enhancement Priority: Low

Comments

@laurenwalker
Copy link
Member

The Fancybox library is currently used for previewing images, maps, and PDFs in the MetadataView. This library is a little overkill for our needs and I believe we can just use Bootstrap's modal feature instead.

This should decrease the size of MetacatUI and reduce the load time of the app, which currently needs to grab extra JS and CSS files for the Fancybox library.
@laurenwalker laurenwalker added this to the 2.1.0 milestone Oct 20, 2017
@laurenwalker laurenwalker self-assigned this Oct 20, 2017
@laurenwalker laurenwalker removed this from the 2.1.0 milestone Jul 11, 2018
@laurenwalker laurenwalker mentioned this issue Aug 6, 2020
Open
@laurenwalker
Copy link
Member Author

In #2027, I found that fancybox slowed down page load since it has 3 separate CSS files and a JS file. Let's replace it or at least lazy load it if we need to keep it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurenwalker laurenwalker

Labels
enhancement Priority: Low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@laurenwalker