Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to enter e-mail addresses outside domain white-list #3421

Open
midmarch opened this issue Feb 1, 2021 · 1 comment
Open

Ability to enter e-mail addresses outside domain white-list #3421

midmarch opened this issue Feb 1, 2021 · 1 comment

Comments

@midmarch
Copy link
Contributor

midmarch commented Feb 1, 2021

Ability to add e-mail addresses outside white-list, as not all users have an e-mail address internally. Currently non existing e-mail addresses are entered to comply with the white-list.

Maybe add a check box, for non deliverable e-mail addressees which do not have to comply with the white-list.

@VassilIordanov
Copy link
Contributor

That ability exists to some extent. We have domainNames and activeDomainNames. The former defines which email domains are allowed at all, the latter defines which ones will get active notifications.

On the longer term, we probably need to ponder on the following:

There are 2 flavors of email addresses:

  • email addresses on which people should receive notifications
  • the email addresses of people for contact reasons
    In most cases they are the same, and we keep track of only 1 email, but they might be on different networks, so we are mixing apples with oranges in a sense

There are 2 type of advisors:

  • active users. Their email address is where they get notifications
  • 3rd party advisors. Their email address is typically just for reference needs

A better longterm solution might be possible if we separate the 2 emails and if we rely on keycloak to populate the emails when available. I suggest to revisit this after a few weeks of keycloak in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants