-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ICCLIM custom indices #450
Comments
Well, that's a lot more complicated than I anticipated. The custom user indices computation is deeply buried in icclim and there seems to be a lot of data preparation before it's called, which as I understand would have to be replicated within ocgis. Christian, suggestions ? Also, is it possible that currently ocgis does not support passing some icclim function parameters. For example RR1 has a parameter called "threshold" and it doesn't seem possible at the moment to assign any value to it from ocgis. |
When I looked at it awhile ago, my thought would be to have ocgis as a very thin layer that mostly just passes through to icclim. It may not be worth it though unless there is a big advantage to using ocgis in all cases.
It would be nice to modify the ocgis-icclim interface to allow arbitrary keyword arguments allowing icclim to evolve without much change to ocgis. That interfaces needs some TLC. |
I agree with Ben's comment. Just having ocgis to act as a thin layer on top of icclim probably the way to go. For icclim parameter passing, I agree that having an interface to pass arbitrary arguments would be the best. It could be gcc-like for example. |
Received a request from another user to implement these. It would be good to identify a path forward for integrating custom indices. Here is the request:
|
'icclim_custom'
'kwds'
function dictionary value will be the keyword arguments toicclim.indice
icclim
documentation for custom indices: http://icclim.readthedocs.io/en/latest/python_api.html#example-3-indice-tg90p-with-callbackPing @nilshempelmann, @pagecp
The text was updated successfully, but these errors were encountered: