-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make IInstantJobRegistry
members return the job correlation id
#153
Conversation
7b315bd
to
8362a30
Compare
Codecov ReportAttention: Patch coverage is
|
8362a30
to
d2ecaec
Compare
I am currently on mobile, will check the whole or later. my Thought (without checking code) might be to expose the IJobContext where there is already the Id. But that might result in a whole bunch of other pitfalls |
d2ecaec
to
3c6c991
Compare
It's not available yet. It's created later, few layers down, by the Besides, only "forced" instant jobs may actually be able to easily return it; the queuing indirection would make it especially complex to directly return it from |
Oh yeah - that is obviously true. It would be more of a |
With all those new changes I would make a new release (stable |
@linkdotnet I'd love that! |
Pull request description
Very first step toward #147 and #36.
Rationale:
In order for the consumer to later be able to poll for (or be notified of) the progress of an orchestration run, getting the correlation id early should be beneficial.
PR meta checklist
main
branch for codeCode PR specific checklist