Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Microsoft.Extensions.Hosting.Abstractions #74

Closed
chrisls121 opened this issue May 28, 2024 · 6 comments
Closed

Use Microsoft.Extensions.Hosting.Abstractions #74

chrisls121 opened this issue May 28, 2024 · 6 comments
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@chrisls121
Copy link

Currently this package references Microsoft.Extensions.Hosting which causes a lot of redundant implicit dependances to be added.

Using Microsoft.Extensions.Hosting.Abstractions greatly reduces the implicit dependances.

I could not find much supporting documentation about the *.Abstractions packages but found a fairly concise explanation on Stack Overflow.

@linkdotnet
Copy link
Member

linkdotnet commented May 28, 2024

That is an excellent idea @chrisls121
There is no real reason to use the non-abstraction package rather than I didn't think of using it in the first place!

That said, I will make a new release soon that drops that dependency!

Much appreciated

@linkdotnet linkdotnet added the dependencies Pull requests that update a dependency file label May 28, 2024
@linkdotnet linkdotnet self-assigned this May 28, 2024
@linkdotnet
Copy link
Member

I merged the change - If it is urgent for you, I can create a new release right away, otherwise I would probably add 1 or 2 more features for a new release.

@linkdotnet
Copy link
Member

Fixed by #75

@chrisls121
Copy link
Author

Thanks @linkdotnet! It is not urgent, I will wait for the new release.

@linkdotnet
Copy link
Member

From 2.6.4-preview this change will be included. If you are willing to add a pre-release, you can "test" the change.

@chrisls121
Copy link
Author

Thanks for the quick resolution, it's working great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants