Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git tag the releases #19

Open
yarikoptic opened this issue Sep 20, 2019 · 4 comments
Open

git tag the releases #19

yarikoptic opened this issue Sep 20, 2019 · 4 comments

Comments

@yarikoptic
Copy link
Contributor

there are versions in CHANGELOG but not a single git tag.

Note: better git tag -a locally, since github doesn't generate annotated tags for the releases

@yarikoptic
Copy link
Contributor Author

uff... I am having "up to date" master and it says

$> vtcmd
Running NDATools Version 0.2.0
Your version of nda-tools is out of date. Please install the latest version (0.2.2) from PyPi or GitHub and try again.

changelog here https://github.com/NDAR/nda-tools/blob/master/CHANGELOG.md#020---2020-04-07 has 0.2.0 as the latest. So where from GitHub I should install from?
I do indeed see 0.2.2 on pypi -- was it just forgotten git push? once again -- please tag the releases!

@RogLee
Copy link

RogLee commented Aug 27, 2020

Hi Yaroslav, the version in the source code is 0.2.0 which does not match with the automatically incremented version in PyPI (0.2.2). They're the same source code. I'll fix the versions later tonight or tomorrow morning and I'll see about adding the git tags.

Thanks!
Roger

@yarikoptic
Copy link
Contributor Author

Great -- thank you in advance!

Could you please point me to a piece of machinery on "automatically incremented version in PyPI"? I am curious since I never saw such a thing I think... we usually first either modify version in the sources and then tag, or use smth like versioneer to tag and make it produce version -- and then upload to pypi already knowing what version would be.

@RogLee
Copy link

RogLee commented Aug 28, 2020

The version is now 0.2.3 in both the source code and on PyPI. PyPI does not allow version replacements so the build number is incremented by one.

I do agree that the version in the code should be updated first and the build process should extract that version and create a tag. The tag has been created by has not been pushed to the GitHub quite yet. On the next release, the deployment plan will extract the tag from our repository and push the tag to GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants