Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to leave "Funding Ask" as blank or TBD #920

Open
elliotBraem opened this issue Aug 7, 2024 · 1 comment
Open

Unable to leave "Funding Ask" as blank or TBD #920

elliotBraem opened this issue Aug 7, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@elliotBraem
Copy link
Contributor

When trying to draft a proposal, I don't know what the funding ask should be yet.

The value defaults as "TBD", but this throws an error when signing the transaction (must be an integer). Then I have to cancel the transaction, leading to #918. Then have to refresh, leading to #919

If I remove "TBD", it seems "T" remains in the transaction (maybe because of debounce? Or some normalization to always keep one value?), causing the error again.

If I input "0", this doesn't seem to be accepted as a "nearest whole positive integer"? So I must enter $1.

Expected

When drafting a proposal, I would like to leave this field as blank or TBD. An empty value should be allowed, and if "TBD" (which is defaulted) remains, maybe this specifically resolves to an empty value as well. A blank value on the proposal view page could show "TBD"

@elliotBraem elliotBraem added the bug Something isn't working label Aug 7, 2024
@ori-near
Copy link
Collaborator

Hey @elliotBraem – thanks for submitting this feedback. We'll review this as a team. I can see how allowing a "0" value while a proposal is in the draft stage would make sense. But if it is being submitted for review, we assume it should have a positive whole number. Can you clarify if you see any other use cases where the amount is not required?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🆕 Triage
Development

No branches or pull requests

2 participants