Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeline checkboxes wrongly get selected when moving a proposal from Draft to Rejected or Canceled #926

Open
ori-near opened this issue Aug 20, 2024 · 4 comments · May be fixed by #930
Open

Timeline checkboxes wrongly get selected when moving a proposal from Draft to Rejected or Canceled #926

ori-near opened this issue Aug 20, 2024 · 4 comments · May be fixed by #930
Labels
bug Something isn't working

Comments

@ori-near
Copy link
Collaborator

Affected Portal:
Select one: DevHub

Description:
When a proposal is in Draft mode, if I try to move it to Cancel or Reject, I noticed that random Timeline checkboxes get checked (e.g. "Sponsor Verifies KYC/KYB" was checked") that are not supposed to.

User Type:
Specify: DevHub Admin

Reproduction Steps

  1. Open a draft proposal (e.g. https://near.social/devhub.near/widget/app?page=proposal&id=102)
  2. Click Admin timeline button
  3. Select the Proposal Status dropdown. Choose Canceled or Rejected.
  4. Notice how various checkboxes get checked under the review stage.

Expected behavior
If I move a proposal from Draft to Canceled or Draft to Rejected, none of the other checkboxes should be checked unless I chose them specifically under the Review stage, which is skipped in this case.

Visual Reference
See video:
https://github.com/user-attachments/assets/36aaed01-3766-43ed-9279-0dff629345b9

Priority
Low (P3) – Minor inconvenience

Environment Details

  • Device: Desktop
  • OS: Mac
  • Browser: Safari
  • Version: Version 17.3.1 (19617.2.4.11.12)
@ori-near ori-near added the bug Something isn't working label Aug 20, 2024
@ori-near ori-near moved this from 🆕 Triage to 🏗 In progress in 🚀 DevHub Products Aug 20, 2024
@ori-near ori-near moved this from 🏗 In progress to 📋 Backlog in 🚀 DevHub Products Aug 20, 2024
@Tguntenaar Tguntenaar self-assigned this Aug 28, 2024
@Tguntenaar Tguntenaar moved this from 📋 Backlog to 🏗 In progress in 🚀 DevHub Products Aug 28, 2024
@Tguntenaar Tguntenaar linked a pull request Aug 28, 2024 that will close this issue
Open
@Tguntenaar
Copy link
Collaborator

I've created a PR and @Megha-Dev-19 pointed out that this effects the last acceptance criteria of #848, so I will write some tests to that both cases show correct behaviour.

@Tguntenaar Tguntenaar moved this from ❌ Blocked to 📋 Backlog in 🚀 DevHub Products Oct 10, 2024
@Tguntenaar
Copy link
Collaborator

Putting this back in the backlog.

If someone is interested in picking it up, it's missing two tests which I made a small start for in timeline.spec.js on PR #930. More details in the are in the file.

@Tguntenaar Tguntenaar removed their assignment Oct 10, 2024
@ori-near
Copy link
Collaborator Author

@Tguntenaar Is there a reason why you can't finish this task? BTW whoever picks up this ticket – it would be great I you can make verify if this is an issue just on DevHub or all instances.

@Tguntenaar
Copy link
Collaborator

@ori-near, the decision was mainly due to shifting priorities to issues with hard deadlines and the need to clean up the board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
🚀 DevHub Products
Status: 📋 Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove checkboxes behaviour from draft to rejected / canceled Tguntenaar/neardevhub-widgets
2 participants
@Tguntenaar @ori-near