Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Sloth bot role model #37

Closed
6 tasks done
Tracked by #41
ftdgoodluck opened this issue May 5, 2024 · 4 comments
Closed
6 tasks done
Tracked by #41

Create Sloth bot role model #37

ftdgoodluck opened this issue May 5, 2024 · 4 comments
Assignees
Milestone

Comments

@ftdgoodluck
Copy link
Collaborator

ftdgoodluck commented May 5, 2024

Create a role model for the bot.

Tasks

Preview Give feedback
  1. bot bot-message
    ftdgoodluck
  2. bot bot-message
    ftdgoodluck
  3. bot bot-message
    ftdgoodluck
  4. bot bot-message
    ftdgoodluck
  5. bot bot-message
    ftdgoodluck
  6. bot bot-message
    ftdgoodluck
@ftdgoodluck ftdgoodluck converted this from a draft issue May 5, 2024
@ftdgoodluck ftdgoodluck self-assigned this May 5, 2024
@ftdgoodluck ftdgoodluck pinned this issue May 5, 2024
@ftdgoodluck ftdgoodluck added this to the MVP milestone May 5, 2024
@ftdgoodluck ftdgoodluck moved this from ❔Triage to 📋 Backlog in Race of Sloths Development May 5, 2024
@ftdgoodluck
Copy link
Collaborator Author

List of supported commands:

For contributors:

  • @sloth include - includes particular PR in Sloth race

For maintainers:

  • @sloth score [1-10] - rates the specific PR that participates in the Sloth race
  • @sloth exclude - excludes particular PR from the Sloth race
  • @sloth pause - pauses bot for a particular repository

Workflow:

  1. Contributor creates a PR with a mention of the Sloth bot using “@sloth include” command
  2. The Sloth bot responds with a like emoji over the description and writes a comment“This pull request was submitted for the Sloth race [active link]”.
  3. Contributor sends PR for a review
  4. Sloth bot writes a comment "This pull request is a part of Sloth race[active link]. Please use the "@sloth reject" command to exclude this pull request from the Sloth race, "@sloth score [1-10]" to rate it, or "@sloth pause" to pause all Sloth race notifications across the project”
  5. If the maintainer writes a comment with “@sloth pause” command, the PR is automatically excluded from Sloth race and all bot actions inside the repo are paused
  6. If the maintainer writes a comment with “@sloth exclude” command, the PR is excluded from the Sloth race
  7. If the maintainer writes a comment with @sloth score X” command, the bot responds with a like emoji over the message and writes a comment “Thanks for submitting your score for the Sloth race [active link]. This score would be recorded once the pull request is merged
  8. If the maintainer writes a comment with “@sloth score” command but with an incorrect token that we can’t parse, the bot writes a comment “Please use the score command with the following syntax: @sloth score + a number between 1 and 10 after a space”

Some thoughts:

  • any type of scoring with multiple parameters would result in a longer explanation message, more mistakes from reviewers and thus more useless messages from the bot asking to write a correct response. Are we OK with that, or it would make more sense to have only one parameter? @frol @botezatunear
  • this flow does not touch some edge cases (multiple reviewers, unpausing bot, etc.)
  • Once we agree on the flow I'll create a diagram for visual explanation

@ftdgoodluck ftdgoodluck moved this from 📋 Backlog to 👀 Review in Race of Sloths Development May 6, 2024
@ftdgoodluck ftdgoodluck mentioned this issue May 6, 2024
@botezatunear
Copy link
Collaborator

I agree that one score will be easier for everyone, I've written thoughts in the specific task:

Let's discuss tomorrow and finalise

@ftdgoodluck ftdgoodluck moved this from 👀 Review to 🔨 In Progress in Race of Sloths Development May 8, 2024
@ftdgoodluck ftdgoodluck moved this from 🔨 In Progress to 🚧 Blocked in Race of Sloths Development May 13, 2024
@ftdgoodluck
Copy link
Collaborator Author

blocked by #46 - once the PRD is finalized this task would be updated

@ftdgoodluck
Copy link
Collaborator Author

@frol @botezatunear @akorchyn waiting for your comments, gentlemen

@ftdgoodluck ftdgoodluck moved this from 🔨 In Progress to 👀 Review in Race of Sloths Development May 22, 2024
This was referenced May 27, 2024
@ftdgoodluck ftdgoodluck moved this from 👀 Review to ✅ Done in Race of Sloths Development Jun 26, 2024
@ftdgoodluck ftdgoodluck closed this as completed by moving to ✅ Done in Race of Sloths Development Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants