Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Configurable Pokemon Sniping #1274

Merged
merged 6 commits into from
Jul 28, 2016
Merged

[Feature] Configurable Pokemon Sniping #1274

merged 6 commits into from
Jul 28, 2016

Conversation

kaeus
Copy link
Contributor

@kaeus kaeus commented Jul 28, 2016

Feature will work with the rest of the logic every 5 Pokestops to snipe configured areas for Pokemon. May need some updates for data calls sine I'm relying on an external API call to determine spawns.

Utilizes two new settings:
bool: SnipeAtPokestops
List: PokemonToSnipe
Example:
"PokemonToSnipe": [
{
"Locations": [
{
"Latitude": 38.556807486461118,
"Longitude": -121.2383794784546
}
],
"Pokemon": "Dratini"
}
]

@Ilses
Copy link
Contributor

Ilses commented Jul 28, 2016

Tested and working great with default settings and SnipeAtPokestops turned on.

@mich3lam
Copy link
Contributor

mich3lam commented Jul 28, 2016

wait. i didnt understand.. how does it know where pokemons are spawning since it requires new location every time .. so in order for it to work and rly snipe a pokemon you want you need to recompile everytime after u add a pokemon

@timelf123
Copy link

timelf123 commented Jul 28, 2016

Magic. Just kidding, everyone knows sniper's scopes let you see things far away

Pokevision

@mich3lam
Copy link
Contributor

@timelf123 useful comment

@Ilses
Copy link
Contributor

Ilses commented Jul 28, 2016

how about magic

@mich3lam
Copy link
Contributor

Oh wow. I missed that part for some reason

@jakesteele
Copy link

Really cool how you incorporated pokevision into the app to snipe pokemon you're looking for :D ill have to manually patch this in on my lunch break. Any issues so far with pokevision blocking your api calls after a while?

@kaeus
Copy link
Contributor Author

kaeus commented Jul 28, 2016

None yet. I'd love to find a different source that we controlled a bit for locations, but the concept seems to be working fine so far.

@goodwind
Copy link

@kaeus why not to use data from #sniping channel on Discord?

@maximegmd maximegmd merged commit d4d3858 into NecronomiconCoding:master Jul 28, 2016
@kaeus
Copy link
Contributor Author

kaeus commented Jul 28, 2016

I want to rework the settings to be easier to manage so you have just a list of locations and a list of pokemon.

@Ilses
Copy link
Contributor

Ilses commented Jul 28, 2016

@goodwind The #sniping channel doesn't have a standardized format yet. Might look into discord API since this is now in the main repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants