Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw away low level pokeballs, potions, revives and keep the better ones. #1362

Merged
merged 6 commits into from
Jul 29, 2016

Conversation

th3ragex
Copy link
Contributor

@th3ragex th3ragex commented Jul 29, 2016

Hi,
i changed the recylce behaviour to throw away low level pokeballs and potions and keep the better ones. This leads to a far more frequent usage of the better pokeballs instead of throwing them away. The new setting entires configure the total amout of pokebals/potions over all types that shall be kept.

@nfettinger
Copy link

nfettinger commented Jul 29, 2016

This is a duplicate issue.

@KicksDNA
Copy link

Is there any way to keep old auth and config files when the bot auto updates??

@th3ragex
Copy link
Contributor Author

th3ragex commented Jul 29, 2016

So this got already implemented by someone else?

@Shibby7986
Copy link

Shibby7986 commented Jul 29, 2016

Edit: Nvm I see your code automates this.
kinda cool

@th3ragex
Copy link
Contributor Author

th3ragex commented Jul 29, 2016

@Shibby7986
I know, but that is not what i wanted and and not what my codes does.

Let me try to explain it. Lets say i configure the bot with the settings you posted. The bot will always throw away greatball until 50 remain, and ultraballs until 100 remain. It will additionally prefer using all normal pokeballs until they are empty. (except a high CP or hard to catch pokemon appreads.)

I changed it to keep, lets say, 100 pokeballs. If i am starving on greatballs the normal pokeballs will be kept, if i get a lot of better pokeballs the bot will keep them and throw the lower pokeballs away. This also reduces the amount of different items which the bot has to throw away => faster.

Changing the config to throw away all lower pokeballs may cause problems if you don't get the higher ones from the pokestops.

@Ryuichiro
Copy link

Looks great, is there a reason you didn't use the same logic for Revive and MaxRevive?

@th3ragex
Copy link
Contributor Author

@Ryuichiro good point, never saw a MaxRevive yet. I will add it right now.

@th3ragex th3ragex changed the title Throw away low level pokeballs and potions and keep the better ones. Throw away low level pokeballs, potions, revives and keep the better ones. Jul 29, 2016
@Suslikuraip
Copy link

Also recycled counter shows how many times recycling was made not actual amount of stuff thrown away.

@Dano7
Copy link

Dano7 commented Jul 29, 2016

Cool change!

@Ryuichiro
Copy link

@th3ragex Do you even use Discord?

@NecronomiconCoding NecronomiconCoding merged commit 901710d into NecronomiconCoding:master Jul 29, 2016
@th3ragex th3ragex deleted the SmartRecycle branch July 29, 2016 23:45
schnapster pushed a commit to schnapster/NecroBot that referenced this pull request Dec 8, 2016
Throw away low level pokeballs, potions, revives and keep the better ones.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants