Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor fixes and improvements #1555

Merged
merged 4 commits into from
Jul 31, 2016

Conversation

actislav
Copy link
Contributor

@actislav actislav commented Jul 31, 2016

Some minor fixes and improvements

@actislav actislav changed the title first launch settings related crush fix and behavior improvements First launch settings related crush fix and behavior improvements Jul 31, 2016
…ly works in tandem with KeepPokemonsThatCanEvolve (with value 0 everything will be the same)

CalculateMaxCp now are using just PokemonId instead PokemonData
Serialization config settings added and changed behavior to persist even default values of object
Snipe in area will use sorted pokemons by MaxCP (maybe, first gather all data from all areas and then sort, for be sure not to use your balls on crap)
# Conflicts:
#	PoGo.NecroBot.CLI/Program.cs
#	PoGo.NecroBot.Logic/Settings.cs
@actislav
Copy link
Contributor Author

actislav commented Jul 31, 2016

EvolveKeptPokemonsAtStorageUsagePercentage config parameter added, only works in tandem with KeepPokemonsThatCanEvolve (with value 0 everything will be the same)

CalculateMaxCp now are using just PokemonId instead PokemonData

Serialization config settings added and changed behavior to persist even default values of object

Snipe in area will use sorted pokemons by MaxCP (maybe, first gather all data from all areas and then sort, for be sure not to use your balls on crap)

Prevent use incorrect player position after possible exception occurred in snipe logic by next state of StateMachine

first start bug fix is not actual (and reverted)

@actislav actislav changed the title First launch settings related crush fix and behavior improvements Some minor fixes and improvements Jul 31, 2016
@NecronomiconCoding NecronomiconCoding merged commit b807aa7 into NecronomiconCoding:master Jul 31, 2016
schnapster pushed a commit to schnapster/NecroBot that referenced this pull request Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants