Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:modal): fix multiple nzOnCancel calls #1590

Merged
merged 1 commit into from
Jun 5, 2018

Conversation

dmytroyarmak
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Double click on cancel button or on "mask" of a modal window causes multiple invocations of ngOnCancel.

Issue Number: #958

What is the new behavior?

Only first click on cancel button or "mask" invokes ngOnCancel.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jun 3, 2018

Codecov Report

Merging #1590 into master will decrease coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1590      +/-   ##
==========================================
- Coverage      96%   95.99%   -0.01%     
==========================================
  Files         466      466              
  Lines       10954    10956       +2     
  Branches     1448     1450       +2     
==========================================
+ Hits        10516    10517       +1     
  Misses        123      123              
- Partials      315      316       +1
Impacted Files Coverage Δ
components/modal/nz-modal.component.ts 96.03% <75%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5c33d0...798dcd1. Read the comment docs.

@vthinkxie vthinkxie requested a review from wilsoncook June 4, 2018 13:27
@vthinkxie vthinkxie merged commit bc07be2 into NG-ZORRO:master Jun 5, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants