Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:carousel): carousel on desktop can't slide images (#1947) #1970

Merged
merged 1 commit into from
Aug 19, 2018
Merged

fix(module:carousel): carousel on desktop can't slide images (#1947) #1970

merged 1 commit into from
Aug 19, 2018

Conversation

ohnow
Copy link
Contributor

@ohnow ohnow commented Aug 11, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1947

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@wzhudev
Copy link
Member

wzhudev commented Aug 12, 2018

@ohnow You should add a test case when you're going to fix a bug.

@wzhudev wzhudev assigned wzhudev and ohnow and unassigned wzhudev Aug 13, 2018
@codecov
Copy link

codecov bot commented Aug 13, 2018

Codecov Report

Merging #1970 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1970   +/-   ##
=======================================
  Coverage   95.98%   95.98%           
=======================================
  Files         470      470           
  Lines       11393    11393           
  Branches     1508     1508           
=======================================
  Hits        10936    10936           
  Misses        131      131           
  Partials      326      326

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30498c8...3aec670. Read the comment docs.

@wzhudev wzhudev requested review from vthinkxie and hsuanxyz and removed request for vthinkxie August 13, 2018 01:10
@hsuanxyz hsuanxyz merged commit 02a84a9 into NG-ZORRO:master Aug 19, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants