fix(module:cascader): search correctly when a root node is a leaf node #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2108 +/- ##
==========================================
+ Coverage 95.96% 95.97% +<.01%
==========================================
Files 473 473
Lines 11516 11516
Branches 1535 1535
==========================================
+ Hits 11051 11052 +1
Misses 132 132
+ Partials 333 332 -1
Continue to review full report at Codecov.
|
zd5043039119
force-pushed
the
cascader/root-leaf-node-filter
branch
2 times, most recently
from
0013a80 to
aa1ec2f
Compare
wzhudev
requested changes
Sep 7, 2018
| @@ -1248,7 +1249,7 @@ export class NzCascaderComponent implements OnInit, OnDestroy, ControlValueAcces | |||
| path.pop(); | |||
| }; | |||
|
|
|||
| this.oldColumnsHolder[ 0 ].forEach(node => loopParent(node)); | |||
| this.oldColumnsHolder[ 0 ].forEach(node => isLeafNode(node) ? loopChild(node) : loopParent(node)); | |||
There was a problem hiding this comment.
We cannot say a node is a leaf node just because it has no children. Though in search mode users cannot load data asynchronously, it would confuse users when they want to load asynchronously, and breaks API consistence in different modes.
|
@zd5043039119 You should add a test case to cover this situation. |
zd5043039119
force-pushed
the
cascader/root-leaf-node-filter
branch
from
aa1ec2f to
65c6268
Compare
zd5043039119
force-pushed
the
cascader/root-leaf-node-filter
branch
from
65c6268 to
3d4e440
Compare
wzhudev
approved these changes
Sep 7, 2018
|
LGTM |
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2104
What is the new behavior?
If a root node is also a leaf node, it can also be searched and highlighted correctly.
Does this PR introduce a breaking change?
Other information