Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:modal): auto focus when open and restore focus when close #2188

Merged
merged 1 commit into from
Oct 11, 2018

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2124

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@hsuanxyz hsuanxyz requested a review from wilsoncook September 25, 2018 07:58
@codecov
Copy link

codecov bot commented Sep 25, 2018

Codecov Report

Merging #2188 into master will decrease coverage by 0.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2188      +/-   ##
==========================================
- Coverage   95.96%   95.95%   -0.02%     
==========================================
  Files         482      482              
  Lines       11965    11983      +18     
  Branches     1594     1598       +4     
==========================================
+ Hits        11482    11498      +16     
  Misses        134      134              
- Partials      349      351       +2
Impacted Files Coverage Δ
components/modal/nz-modal.component.ts 95.31% <88.88%> (-0.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95954cc...5326aa0. Read the comment docs.

@vthinkxie vthinkxie merged commit 7c0ced4 into NG-ZORRO:master Oct 11, 2018
wzhudev pushed a commit to wzhudev/ng-zorro-antd that referenced this pull request Oct 15, 2018
@hsuanxyz hsuanxyz deleted the modal/feta-focus branch October 23, 2018 10:35
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants