Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: drawer, modal): fix focus bug of IE #2589

Merged
merged 2 commits into from
Dec 11, 2018

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Dec 5, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2388

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Dec 5, 2018

Deploy preview for ng-zorro-master ready!

Built with commit 964efc4

https://deploy-preview-2589--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Dec 5, 2018

Codecov Report

Merging #2589 into master will decrease coverage by <.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2589      +/-   ##
==========================================
- Coverage    95.5%   95.49%   -0.01%     
==========================================
  Files         495      495              
  Lines       12098    12101       +3     
  Branches     1689     1690       +1     
==========================================
+ Hits        11554    11556       +2     
  Misses        172      172              
- Partials      372      373       +1
Impacted Files Coverage Δ
components/modal/nz-modal.component.ts 95.85% <100%> (ø) ⬆️
components/drawer/nz-drawer.service.ts 100% <100%> (ø) ⬆️
components/drawer/nz-drawer.component.ts 97.61% <66.66%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef10595...964efc4. Read the comment docs.

@hsuanxyz hsuanxyz merged commit 0458604 into NG-ZORRO:master Dec 11, 2018
@hsuanxyz hsuanxyz deleted the fix/ie-focus branch January 8, 2019 12:11
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* fix(module: drawer, modal): fix focus bug of IE
* fix(module:drawer): prevent repeatedly open drawer when tap focus element

close NG-ZORRO#2388
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant