Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:all): move hostbinding to constructor to fix angular trans… #2895

Merged
merged 1 commit into from
Feb 15, 2019
Merged

fix(module:all): move hostbinding to constructor to fix angular trans… #2895

merged 1 commit into from
Feb 15, 2019

Conversation

vthinkxie
Copy link
Member

…ition bug

close #2697 close #2894

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2697 #2894

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@netlify
Copy link

netlify bot commented Feb 15, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 5c8dc93

https://deploy-preview-2895--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #2895 into master will decrease coverage by 0.02%.
The diff coverage is 95.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2895      +/-   ##
==========================================
- Coverage   97.39%   97.36%   -0.03%     
==========================================
  Files         526      526              
  Lines       10954    11025      +71     
  Branches      785      785              
==========================================
+ Hits        10669    10735      +66     
- Misses        184      189       +5     
  Partials      101      101
Impacted Files Coverage Δ
components/radio/nz-radio.component.ts 100% <100%> (ø) ⬆️
components/dropdown/nz-dropdown.directive.ts 100% <100%> (ø) ⬆️
components/breadcrumb/nz-breadcrumb.component.ts 57.14% <100%> (+1.26%) ⬆️
components/tabs/nz-tabs-ink-bar.directive.ts 96.55% <100%> (+0.12%) ⬆️
components/layout/nz-sider.component.ts 95.83% <100%> (+0.08%) ⬆️
components/card/nz-card-loading.component.ts 100% <100%> (ø) ⬆️
components/layout/nz-layout.component.ts 100% <100%> (ø) ⬆️
components/layout/nz-header.component.ts 100% <100%> (ø) ⬆️
components/form/nz-form-control.component.ts 100% <100%> (ø) ⬆️
components/card/nz-card-grid.directive.ts 100% <100%> (ø) ⬆️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea7e8e9...5c8dc93. Read the comment docs.

@vthinkxie vthinkxie merged commit e39f6bf into NG-ZORRO:master Feb 15, 2019
@vthinkxie vthinkxie deleted the fix-transition branch February 26, 2019 07:08
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace host class binding true in constructor unexpected transition when router change
1 participant