Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nz-progress incorrectly shows progress complete when nzSuccessPercent < 100 #3128

Closed
anantoghosh opened this issue Mar 20, 2019 · 0 comments · Fixed by #3135
Closed

nz-progress incorrectly shows progress complete when nzSuccessPercent < 100 #3128

anantoghosh opened this issue Mar 20, 2019 · 0 comments · Fixed by #3135

Comments

@anantoghosh
Copy link

Reproduction link

https://stackblitz.com/edit/ng-zorro-antd-start-iizuvf?file=src/app/app.component.html

Steps to reproduce

In nz-progress, use nzSuccessPercent with nzPercent. Set nzPercent to 100, nzSuccessPercent to < 100.

What is expected?

Progress does not show complete until nzSuccessPercent is set to 100.
Correct behavior shown in react component: https://codesandbox.io/s/67w2r695n

What is actually happening?

Progress status changes to 'success' when nzPercent changes to 100, ignoring nzSuccessPercent value.

Environment Info
ng-zorro-antd 7.0.3
Browser Chrome latest/Firefox latest
@anantoghosh anantoghosh changed the title ng-progress incorrectly shows progress complete when nzSuccessPercent < 100 nz-progress incorrectly shows progress complete when nzSuccessPercent < 100 Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants