feat(module:tree-select): support customized icon #3395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ng-zorro-master ready! Built with commit d95c32f |
Codecov Report
@@ Coverage Diff @@
## master #3395 +/- ##
==========================================
- Coverage 96.66% 95.48% -1.19%
==========================================
Files 609 609
Lines 13187 13189 +2
Branches 1803 1803
==========================================
- Hits 12747 12593 -154
- Misses 199 215 +16
- Partials 241 381 +140
Continue to review full report at Codecov.
|
hsuanxyz
requested changes
May 3, 2019
components/tree/nz-tree.component.ts
Outdated
| @@ -83,6 +83,8 @@ export class NzTreeComponent extends NzTreeBase implements OnInit, OnDestroy, Co | |||
| @Input() @InputBoolean() nzCheckStrictly = false; | |||
| @Input() @InputBoolean() nzBlockNode = false; | |||
|
|
|||
| @Input() nzTreeSelectTemplate: TemplateRef<void>; | |||
There was a problem hiding this comment.
Suggested change
| @Input() nzTreeSelectTemplate: TemplateRef<void>; | |
| @Input() nzTreeSelectTemplate: TemplateRef<{ $implicit: NzTreeNode }>; |
还有其他几个漏掉的地方，应该一起补上
fix: change tree template type
wenqi73
force-pushed
the
tree-select-customized-icon
branch
from
1537e9c to
09225ca
Compare
hsuanxyz
approved these changes
May 4, 2019
|
https://stackblitz.com/edit/contentchild-input-sametime 测了下，同时存在会优先取 |
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
* feat(module:tree-select): support customized icon * feat: support nzTreeTemplate to customize icon fix: change tree template type * feat: support tree template as @input and @ContentChild
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
* feat(module:tree-select): support customized icon * feat: support nzTreeTemplate to customize icon fix: change tree template type * feat: support tree template as @input and @ContentChild
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3330
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
tree-select 初始状态下无法获取
treeRef，所以在 tree 里面加了nzTreeSelectTemplate来传递 template