Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:select): support global config nzSuffixIcon #5092

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

vthinkxie
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Apr 21, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #5092 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5092      +/-   ##
==========================================
- Coverage   91.47%   91.45%   -0.03%     
==========================================
  Files         546      546              
  Lines       13734    13736       +2     
  Branches     2128     2128              
==========================================
- Hits        12563    12562       -1     
- Misses        707      708       +1     
- Partials      464      466       +2     
Impacted Files Coverage Δ
components/core/config/config.ts 100.00% <ø> (ø)
components/select/select-arrow.component.ts 100.00% <100.00%> (ø)
components/select/select.component.ts 90.60% <100.00%> (+0.07%) ⬆️
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️
components/time-picker/time-holder.ts 94.73% <0.00%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b61a914...3d08aa3. Read the comment docs.

wzhudev
wzhudev previously approved these changes Apr 21, 2020
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

| `[nzRemoveIcon]` | The custom remove icon | `TemplateRef<void>` | - |
| `[nzClearIcon]` | The custom clear icon | `TemplateRef<void>` | - |
| `[nzMenuItemSelectedIcon]` | The custom menuItemSelected icon | `TemplateRef<void>` | - |
| `[nzSuffixIcon]` | The custom suffix icon | `TemplateRef<any> \| string` | - |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文档这里添加最后一列的小对勾,标明可以使用全局配置项目

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@vthinkxie vthinkxie force-pushed the support-select-suffix-icon branch from c3ecbbf to 3d08aa3 Compare April 21, 2020 12:38
@vthinkxie vthinkxie merged commit ad847e7 into NG-ZORRO:master Apr 21, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants