-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:select): support global config nzSuffixIcon #5092
feat(module:select): support global config nzSuffixIcon #5092
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #5092 +/- ##
==========================================
- Coverage 91.47% 91.45% -0.03%
==========================================
Files 546 546
Lines 13734 13736 +2
Branches 2128 2128
==========================================
- Hits 12563 12562 -1
- Misses 707 708 +1
- Partials 464 466 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
components/select/doc/index.en-US.md
Outdated
| `[nzRemoveIcon]` | The custom remove icon | `TemplateRef<void>` | - | | ||
| `[nzClearIcon]` | The custom clear icon | `TemplateRef<void>` | - | | ||
| `[nzMenuItemSelectedIcon]` | The custom menuItemSelected icon | `TemplateRef<void>` | - | | ||
| `[nzSuffixIcon]` | The custom suffix icon | `TemplateRef<any> \| string` | - | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
文档这里添加最后一列的小对勾,标明可以使用全局配置项目
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
c3ecbbf
to
3d08aa3
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information