Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:select): support input nzOptions in select #5109

Merged
merged 1 commit into from
Apr 26, 2020

Conversation

vthinkxie
Copy link
Member

close #5106

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Apr 22, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #5109 into master will increase coverage by 0.02%.
The diff coverage is 91.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5109      +/-   ##
==========================================
+ Coverage   91.43%   91.46%   +0.02%     
==========================================
  Files         547      547              
  Lines       13768    13786      +18     
  Branches     2137     2146       +9     
==========================================
+ Hits        12589    12609      +20     
+ Misses        712      707       -5     
- Partials      467      470       +3     
Impacted Files Coverage Δ
components/select/select.component.ts 90.14% <91.42%> (-0.47%) ⬇️
components/table/src/table/tr-measure.component.ts 100.00% <0.00%> (+13.04%) ⬆️
components/table/src/table/tbody.component.ts 100.00% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7870e67...2388977. Read the comment docs.

@vthinkxie vthinkxie force-pushed the select-support-options branch 3 times, most recently from f609db8 to 30957da Compare April 26, 2020 07:14
@vthinkxie vthinkxie changed the title [WIP]feat(module:select): support input nzOptions in select feat(module:select): support input nzOptions in select Apr 26, 2020
@vthinkxie vthinkxie force-pushed the select-support-options branch from 30957da to 2388977 Compare April 26, 2020 07:32
@vthinkxie vthinkxie merged commit 251a064 into NG-ZORRO:master Apr 26, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support pass options data as @Input to nz-select
1 participant