Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:i18n): some locales compile error #5445

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Jun 17, 2020

Fixes #5444

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jun 17, 2020

This preview will be available after the AzureCI is passed.

@wenqi73 wenqi73 changed the title fix(module:i18n): some locales compiles error fix(module:i18n): some locales compile error Jun 17, 2020
@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #5445 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5445   +/-   ##
=======================================
  Coverage   91.22%   91.22%           
=======================================
  Files         453      453           
  Lines       13877    13877           
  Branches     2129     2129           
=======================================
  Hits        12659    12659           
  Misses        721      721           
  Partials      497      497           
Impacted Files Coverage Δ
components/date-picker/date-picker.component.ts 96.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15b7cc2...44e7618. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vthinkxie vthinkxie merged commit e9ef9f3 into NG-ZORRO:master Jun 17, 2020
@wenqi73 wenqi73 deleted the i18n-interface branch June 17, 2020 11:13
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i18n for other locales than en_US does not compile
2 participants