feat(module:datepicker): add range-picker component #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsuanxyz
changed the title
hsuanxyz
force-pushed
the
feat-datepacker-range
branch
from
c08127b to
268afb6
Compare
hsuanxyz
force-pushed
the
feat-datepacker-range
branch
from
268afb6 to
c02d918
Compare
hsuanxyz
force-pushed
the
feat-datepacker-range
branch
from
c02d918 to
d5bad61
Compare
hsuanxyz
force-pushed
the
feat-datepacker-range
branch
from
05d6124 to
697d1cb
Compare
hsuanxyz
force-pushed
the
feat-datepacker-range
branch
from
697d1cb to
0436b4a
Compare
hsuanxyz
force-pushed
the
feat-datepacker-range
branch
from
0436b4a to
a7be9e7
Compare
hsuanxyz
force-pushed
the
feat-datepacker-range
branch
from
a7be9e7 to
a6219fd
Compare
hsuanxyz
changed the title
|
Ready for review |
hsuanxyz
commented
Dec 22, 2017
| @@ -46,6 +47,8 @@ export interface WeekInterface { | |||
| days: DayInterface[]; | |||
| } | |||
|
|
|||
| export enum RangePart { Start = 0, End = 1 } | |||
There was a problem hiding this comment.
使用 enum 代替数组下标来表示开始和结束。
hsuanxyz
commented
Dec 22, 2017
| <div class="ant-calendar-date-panel"> | ||
| <ng-container *ngTemplateOutlet="calendarRangePart; context: { part: _part.Start }"></ng-container> | ||
| <span class="ant-calendar-range-middle">~</span> | ||
| <ng-container *ngTemplateOutlet="calendarRangePart; context: { part: _part.End }"></ng-container> |
There was a problem hiding this comment.
这里用 ng-container 创建了日历的两个部分，在它们内部使用 part 变量区分。
hsuanxyz
commented
Dec 22, 2017
| this._disabledDatePart[RangePart.End] = this._mode[RangePart.End] === 'month' ? null : this._disabledDate; | ||
| } | ||
|
|
||
| _generateYearPanel(): void { |
There was a problem hiding this comment.
这个方法与 nz-datepicker 组件代码一样，可以考虑写公共部分。
3 tasks
feat(module:datepicker): support [nzShowTime] feat(module:datepicker): hover to highlight the range feat(module:datepicker): support input export component
hsuanxyz
force-pushed
the
feat-datepacker-range
branch
from
a6219fd to
fe401b4
Compare
hsuanxyz
commented
Jan 6, 2018
| @@ -34,6 +34,8 @@ export const trTR: NzLocale = { | |||
| chooseDate: 'Tarih seçin', | |||
| chooseTimePlease: 'Saat seçin', | |||
| chooseDatePlease: 'Tarih seçin', | |||
| chooseStartDatePlease: 'Başlangıç tarihi', | |||
| chooseEndDatePlease: 'Bitiş tarihi', | |||
There was a problem hiding this comment.
@zverbeta please review this translation, thanks!
hsuanxyz
added a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
* feat(module:datepicker): add range-picker component feat(module:datepicker): support [nzShowTime] feat(module:datepicker): hover to highlight the range feat(module:datepicker): support input export component * feat(module:locale): add russian locale for the date range component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #646 -
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Checklist
nzSizenzFormatnzDisablednzDisabledDatenzShowTime