Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion over history variable long names #1199

Open
JessicaNeedham opened this issue May 15, 2024 · 1 comment
Open

Confusion over history variable long names #1199

JessicaNeedham opened this issue May 15, 2024 · 1 comment

Comments

@JessicaNeedham
Copy link
Contributor

Some of the FATES history variables have long names that (I think) are incorrect. I thought that FATES history variables are output only for the naturally vegetated columns that FATES runs on, but many have ‘per land area’ in the long name. To be correct I think the long name should say ‘per naturally vegetated land area’. But I wonder if it makes more sense to just cut that bit and have a section in the user guide describing how outputs need to be interpreted?

To get history variables to be per land area we need to multiply by FATES_FRACTION. The comments around FATES_FRACTION describe it as the fraction of the whole grid cell that FATES runs over, but by default CLM and ELM history variables are not weighted by land fraction so I think it is actually the fraction of the land portion of the grid cell. In post processing global and regional runs should we be multiplying by FATES_FRACTION and land fraction?

I think we should shorten long names so they don’t refer to land area and 2) provide a section in the user guide for how to interpret history variables. Have I understood correctly? Do people agree?

@jennykowalcz
Copy link

I think we should shorten long names so they don’t refer to land area and 2) provide a section in the user guide for how to interpret history variables. Have I understood correctly? Do people agree?

I think this would be really helpful! I have definitely found it confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ❕Todo
Development

No branches or pull requests

2 participants