Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--garble option doesn't work after the latest update #174

Closed
x9xhack opened this issue Oct 27, 2024 · 4 comments
Closed

--garble option doesn't work after the latest update #174

x9xhack opened this issue Oct 27, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@x9xhack
Copy link

x9xhack commented Oct 27, 2024

I tried to find the case and it happens only when I add the --garble option

catcher$ link --goos windows --garble --upx
Error: exit status 1
'# github.com/NHAS/reverse_ssh/cmd/client'
EkvaE4.(*W5Oean).ReadSSHPacket: relocation target Mn3aMa.(*fWGdqLcSj).igWwMId not defined
exit status 2
exit status 1

@x9xhack x9xhack changed the title --garble option doesn't work after latest update --garble option doesn't work after the latest update Oct 27, 2024
@NHAS
Copy link
Owner

NHAS commented Oct 27, 2024

Ah fuck, that'll be because garble is fucking up the function signature when linking in from the std library.

err = adjustWindow(m.channelPtr, uint32(len(buff)))

Not entirely sure how to fix this but i'll update if I can get it working

@NHAS NHAS self-assigned this Oct 27, 2024
@NHAS NHAS added the bug Something isn't working label Oct 27, 2024
@NHAS
Copy link
Owner

NHAS commented Oct 27, 2024

Sweet, thanks for opening the issue. I've raised a PR with garble as they have a problem interpreting the go:linkname when reflection is being used.

You can see it here.

burrowers/garble#883

I'll do a new release when they've fixed it, or if they take a little while I'll use my fork.

@x9xhack
Copy link
Author

x9xhack commented Oct 27, 2024

thanks bro for your swift reply

@NHAS
Copy link
Owner

NHAS commented Nov 2, 2024

This is now on main, and I've updated the docker container. If you're using the binary install for the server, please install garble@master, rather than latest :)

@NHAS NHAS closed this as completed Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants