rssh-download channel gets sent to the user's SSH client instead of the Server's SSH connection in Jump Host Mode

[ld-carapace]

Detail

When connecting to an RSSH client in jump host mode, i.e. -J myrsshserver my-client-name, the rssh-download channel is sent to the user's SSH client, rather than to the RSSH server.

Logs

when trying to do ssh -v myrsshclient rssh://busybox:

debug1: Sending command: rssh://busybox
debug1: client_input_channel_open: ctype rssh-download rchan 1 win 2097152 max 32768
debug1: failure rssh-download
ssh: rejected: administratively prohibited (open failed)

Root Cause Analysis:

When download is called, the argument "serverConnection" is a slight misnomer - it's actually the session-specific connection.

reverse_ssh/internal/client/handlers/session.go

Line 234 in f5d2a6c

ch, reqs, err := serverConnection.OpenChannel("rssh-download", []byte(filename))

Is set in NewSession here:

reverse_ssh/internal/client/connection/connection.go

Lines 26 to 29 in f5d2a6c

	func NewSession(connection ssh.Conn) *Session {
	return &Session{
	ServerConnection: connection,

Which is constructed here in jump host mode:

reverse_ssh/internal/client/handlers/jumphost.go

Line 55 in f5d2a6c

session := connection.NewSession(conn)