Show hidden offers to admin #291

diogofonte · 2022-12-13T15:37:11Z

Closes #236

Naapperas · 2022-12-22T14:51:05Z

@CarlosMealha @diogofonte any updates on this?

diogofonte · 2022-12-22T16:33:05Z

@CarlosMealha @diogofonte any updates on this?

We were waiting for opinions about the divs that are causing extra space in mobile view search, but the button "show hidden offers" is ready.
This is not the not the principal objective of this PR, but the problem affects directly our issue.

CarlosMealha · 2022-12-22T16:42:41Z

@CarlosMealha @diogofonte any updates on this?

Also, is there any endpoint responsible to fetch hidden offers or we need to filter the offers in order to specify them ?

Naapperas · 2022-12-23T18:44:51Z

@CarlosMealha @diogofonte any updates on this?

Also, is there any endpoint responsible to fetch hidden offers or we need to filter the offers in order to specify them ?

the GET /offers endpoint already handles this: you need to pass a query value named showHidden, if I recall correctly, and set it to true in order to see hidden offers (if you have permission to do so of course).

If you are asking in the context of this PR, the feature that needs to be implemented is the possibility for admins to pass that showHidden value, which is currently not possible. Maybe I misunderstood your question.

Naapperas · 2022-12-23T18:48:11Z

@CarlosMealha @diogofonte any updates on this?

We were waiting for opinions about the divs that are causing extra space in mobile view search, but the button "show hidden offers" is ready. This is not the not the principal objective of this PR, but the problem affects directly our issue.

I think I looked around a while ago and recall this being an issue in the MultiOptionAutocomplete component, not that one, but i might be wrong. If the problem is in the component you showed maybe you could replace the React Fragment (the <></> thing) with null and see if it works.

CarlosMealha · 2022-12-24T13:34:25Z

@CarlosMealha @diogofonte any updates on this?

Also, is there any endpoint responsible to fetch hidden offers or we need to filter the offers in order to specify them ?

the GET /offers endpoint already handles this: you need to pass a query value named showHidden, if I recall correctly, and set it to true in order to see hidden offers (if you have permission to do so of course).

If you are asking in the context of this PR, the feature that needs to be implemented is the possibility for admins to pass that showHidden value, which is currently not possible. Maybe I misunderstood your question.

Yes, my question was about the endpoint specifically, and your answer cleared my doubts. Thank you!

CarlosMealha · 2023-01-24T15:18:17Z

Okay, me and Diogo made the show hidden toggle on admin account working properly

Naapperas · 2023-01-24T15:46:23Z

Since there is no backend to test this (at the moment), please include a small video demonstrating this feature.

Naapperas

There should be tests regarding the UI and Request making parts of this feature, not just the Redux store one.

Naapperas · 2023-02-01T12:28:59Z

Also, beware of the upstream changes, you'll need to rebase this branch with develop later.

src/actions/searchOffersActions.spec.js

codecov-commenter · 2023-02-12T13:15:32Z

Codecov Report

Patch coverage: 70.37% and project coverage change: -0.21 ⚠️

Comparison is base (e2c6463) 89.05% compared to head (5626b67) 88.84%.

❗ Current head 5626b67 differs from pull request most recent head 1d046e2. Consider uploading reports for the commit 1d046e2 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #291      +/-   ##
===========================================
- Coverage    89.05%   88.84%   -0.21%     
===========================================
  Files          176      175       -1     
  Lines         3390     3345      -45     
  Branches       851      845       -6     
===========================================
- Hits          3019     2972      -47     
- Misses         371      373       +2

Impacted Files	Coverage Δ
...ltsArea/SearchResultsWidget/SearchResultsMobile.js	`80.00% <ø> (ø)`
...mponents/HomePage/SearchArea/useUrlSearchParams.js	`89.79% <16.66%> (-8.45%)`	⬇️
...SearchArea/AdvancedSearch/AdvancedSearchDesktop.js	`91.66% <75.00%> (-8.34%)`	⬇️
.../SearchArea/AdvancedSearch/AdvancedSearchMobile.js	`77.41% <75.00%> (-0.36%)`	⬇️
...age/SearchArea/AdvancedSearch/useAdvancedSearch.js	`96.77% <83.33%> (-3.23%)`	⬇️
src/actions/searchOffersActions.js	`100.00% <100.00%> (ø)`
src/components/HomePage/SearchArea/SearchArea.js	`100.00% <100.00%> (+2.12%)`	⬆️
src/reducers/searchOffersReducer.js	`100.00% <100.00%> (+3.63%)`	⬆️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

CarlosMealha · 2023-02-12T13:20:56Z

Codecov Report

Base: 88.98% // Head: 88.96% // Decreases project coverage by -0.03% warning

Coverage data is based on head (6e15449) compared to base (5f96cb4).
Patch coverage: 85.71% of modified lines in pull request are covered.

mega This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files

umbrella View full report at Codecov. loudspeaker Do you have feedback about the report comment? Let us know in this issue.

We will take care of this as the feature for the related showHidden URL filter are still in progress and the corresponding tests

src/components/HomePage/SearchArea/SearchArea.js

diogofonte · 2023-02-28T19:52:53Z

Now the showHidden attribute is present in the URL

Video demonstrating the final result:

show_hidden_offers.mp4

BrunoRosendo · 2023-03-01T15:16:17Z

I'll leave the code review for the others but I think the result looks neat!

Co-authored by: CarlosMealha up202005954@edu.fc.up.pt

…ns inside of the advancedSearchContainer grid

Co-authored by: CarlosMealha up202005954@edu.fc.up.pt

Co-authored-by: diogofonte <diogo.fonte2000@gmail.com>

…s-fe into feature/showHiddenToAdmin

tomaspalma

Everything looks good and is working.

There is just a small detail that in terms of functionality doesn't really matter probably, but basically, if a user without privileges types showHidden=false or true, it shows a dot on the settings icon near the search bar, but then when we click it, in the advanced filters menu, there is obviously nothing there.

However, I believe this doesn't do anything because as far as I saw, the backend checks if a user has privileges or not to show the hidden offer and his an edge case that would probably never happen, so it's not that important.

Naapperas

Left a small comment.

@DoStini please review this code once more, since Github is picky about change requests 🙃

Naapperas · 2023-06-18T22:27:18Z

src/components/HomePage/SearchArea/searchAreaStyle.js

+        gridRowStart: 4,
+        gridColumnStart: 2,
+    },
+    spaceBtwn: {


I'm not a big fan of this: this class should have another name, and not one that simply re-states what it does style-wise.

Naapperas · 2023-06-18T22:33:28Z

Also, don't forget to rebase.

diogofonte assigned CarlosMealha and diogofonte Dec 13, 2022

CarlosMealha force-pushed the feature/showHiddenToAdmin branch from a8d6e06 to 04a1c18 Compare January 24, 2023 15:24

CarlosMealha requested review from BrunoRosendo and Naapperas January 24, 2023 15:26

CarlosMealha force-pushed the feature/showHiddenToAdmin branch 2 times, most recently from ed77758 to 598f1ae Compare January 24, 2023 16:36

Naapperas requested changes Feb 1, 2023

View reviewed changes

CarlosMealha force-pushed the feature/showHiddenToAdmin branch from 726749a to bcb8ca8 Compare February 7, 2023 15:32

CarlosMealha requested a review from Naapperas February 7, 2023 15:44

DoStini requested changes Feb 11, 2023

View reviewed changes

src/actions/searchOffersActions.spec.js Outdated Show resolved Hide resolved

CarlosMealha force-pushed the feature/showHiddenToAdmin branch from 6e15449 to 695e803 Compare February 12, 2023 13:16

Naapperas requested changes Feb 12, 2023

View reviewed changes

src/components/HomePage/SearchArea/SearchArea.js Show resolved Hide resolved

CarlosMealha force-pushed the feature/showHiddenToAdmin branch from be605e5 to d2acc37 Compare February 28, 2023 13:55

diogofonte force-pushed the feature/showHiddenToAdmin branch 2 times, most recently from b3433d2 to 140ea74 Compare February 28, 2023 18:57

diogofonte force-pushed the feature/showHiddenToAdmin branch from b91bae4 to b3094dc Compare March 6, 2023 23:06

diogofonte and others added 19 commits May 23, 2023 09:58

feature: adds show hidden to url

f4221fa

Co-authored by: CarlosMealha up202005954@edu.fc.up.pt

reset fields working with show hidden offers

56ea8a7

fix lint error

a9427b7

fix lint error

5dcf960

feature: show hidden button style done on desktop

043e35a

feat: showHidden is already working

9a3493d

feature: show hidden button style done on desktop

4c8a84a

feat: inserted the reset advanced search and show hidden offers butto…

8248a74

…ns inside of the advancedSearchContainer grid

feat: showHidden is already working

ba8601e

tests: adds various tests to showHidden

45389c2

feature: adds show hidden to url

7c0378a

Co-authored by: CarlosMealha up202005954@edu.fc.up.pt

reset fields working with show hidden offers

bb39894

fix lint error

e01a861

fix lint error

b7412a0

fix: wrong tests

b013fef

tests: progress

b4f729b

tests: fixed frontend tests

0b58f92

Co-authored-by: diogofonte <diogo.fonte2000@gmail.com>

fix: show hidden state

a06e434

Merge branch 'feature/showHiddenToAdmin' of github.com:NIAEFEUP/nijob…

1d046e2

…s-fe into feature/showHiddenToAdmin

CarlosMealha force-pushed the feature/showHiddenToAdmin branch from 210f355 to 1d046e2 Compare May 23, 2023 09:48

CarlosMealha requested a review from Naapperas May 23, 2023 09:51

Naapperas requested review from tomaspalma, Process-ing and CiscoPr and removed request for DoStini, Naapperas and BrunoRosendo May 23, 2023 13:40

tomaspalma approved these changes Jun 13, 2023

View reviewed changes

Naapperas requested changes Jun 18, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show hidden offers to admin #291

Show hidden offers to admin #291

diogofonte commented Dec 13, 2022 •

edited

Loading

Naapperas commented Dec 22, 2022

diogofonte commented Dec 22, 2022

CarlosMealha commented Dec 22, 2022

Naapperas commented Dec 23, 2022

Naapperas commented Dec 23, 2022

CarlosMealha commented Dec 24, 2022

CarlosMealha commented Jan 24, 2023

Naapperas commented Jan 24, 2023

Naapperas left a comment

Naapperas commented Feb 1, 2023

codecov-commenter commented Feb 12, 2023 •

edited by codecov bot

Loading

CarlosMealha commented Feb 12, 2023

Codecov Report

diogofonte commented Feb 28, 2023

BrunoRosendo commented Mar 1, 2023

tomaspalma left a comment •

edited

Loading

Naapperas left a comment

Naapperas Jun 18, 2023

Naapperas commented Jun 18, 2023

Show hidden offers to admin #291

Are you sure you want to change the base?

Show hidden offers to admin #291

Conversation

diogofonte commented Dec 13, 2022 • edited Loading

Naapperas commented Dec 22, 2022

diogofonte commented Dec 22, 2022

CarlosMealha commented Dec 22, 2022

Naapperas commented Dec 23, 2022

Naapperas commented Dec 23, 2022

CarlosMealha commented Dec 24, 2022

CarlosMealha commented Jan 24, 2023

Naapperas commented Jan 24, 2023

Naapperas left a comment

Choose a reason for hiding this comment

Naapperas commented Feb 1, 2023

codecov-commenter commented Feb 12, 2023 • edited by codecov bot Loading

Codecov Report

CarlosMealha commented Feb 12, 2023

Codecov Report

diogofonte commented Feb 28, 2023

BrunoRosendo commented Mar 1, 2023

tomaspalma left a comment • edited Loading

Choose a reason for hiding this comment

Naapperas left a comment

Choose a reason for hiding this comment

Naapperas Jun 18, 2023

Choose a reason for hiding this comment

Naapperas commented Jun 18, 2023

diogofonte commented Dec 13, 2022 •

edited

Loading

codecov-commenter commented Feb 12, 2023 •

edited by codecov bot

Loading

tomaspalma left a comment •

edited

Loading