allow non boolean simple conditionals #454
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Previously, the SimpleConditional logic only checked for an array key and its value, i.e.
for formio data like:
However,
SelectBoxes
andSelect
with the multivalue option enabled format their values differently, leading toSimpleConditional::invoke()
always returning false and the components' values being ignored during validations. An example in SOAP is, because the values of these ignored components are not persisted, missing PDF uploads:This PR expands the SimpleConditional logic to cover these cases, handling the following:
and
So now all the conditionals shown below just work(tm), and values will be persisted.
Checklist
tests/
added or updated