New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SlugField in all model identifiers #101

Open

7 tasks

ghoshbishakh opened this issue Feb 1, 2017 · 0 comments

Labels

difficulty/low importance/high

Member

ghoshbishakh commented Feb 1, 2017

Identifiers are used in urls. So using a slugfield instead of custom regex will be better.

https://docs.djangoproject.com/en/1.10/ref/models/fields/#slugfield

So tasks are:

Change Event identifier https://github.com/NIT-dgp/festcms/blob/master/festflow/models.py#L20
Change Keynote identifier https://github.com/NIT-dgp/festcms/blob/master/festflow/models.py#L57
Change About identifier https://github.com/NIT-dgp/festcms/blob/master/festflow/models.py#L147
Change NewsLetter identifier https://github.com/NIT-dgp/festcms/blob/master/festflow/models.py#L160
Change Subscription identifier https://github.com/NIT-dgp/festcms/blob/master/festflow/models.py#L170
Change FAQ identifier https://github.com/NIT-dgp/festcms/blob/master/festflow/models.py#L187
Remove the regex: https://github.com/NIT-dgp/festcms/blob/master/festflow/models.py#L11

ghoshbishakh added difficulty/low importance/high labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment