Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pkg workflow to use latest Ploutos #993

Closed
ximon18 opened this issue Jan 12, 2023 · 3 comments · Fixed by #1193
Closed

Upgrade pkg workflow to use latest Ploutos #993

ximon18 opened this issue Jan 12, 2023 · 3 comments · Fixed by #1193
Labels

Comments

@ximon18
Copy link
Member

ximon18 commented Jan 12, 2023

Currently the packaging workflow uses Ploutos @v1 while the latest is @v5.2.0.

Upgrading would resolve this warning currently being produced by Krill packaging workflow runs:

The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

It will likely also add more checks and speed improvements in the packaging process and simplify the inputs needed from Krill.

@ximon18
Copy link
Member Author

ximon18 commented Jan 3, 2024

Krill was since updated to use Ploutos v6, but the latest is v7 so this issue is actually still relevant.

@ximon18
Copy link
Member Author

ximon18 commented Jan 18, 2024

Upgrading to Ploutos v7 should fix #1184.

@ximon18
Copy link
Member Author

ximon18 commented Jan 18, 2024

A test run with Ploutos v7 failed but may just be because the version in the Krill Cargo.toml in the issue branch needs bumping.

@ximon18 ximon18 linked a pull request Apr 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant