Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSD stats contain the terms "master" and "slave" #310

Closed
anandb-ripencc opened this issue Dec 7, 2023 · 1 comment
Closed

NSD stats contain the terms "master" and "slave" #310

anandb-ripencc opened this issue Dec 7, 2023 · 1 comment

Comments

@anandb-ripencc
Copy link
Contributor

Hi. I've just noticed that the stats output of nsd-control stats prints zone.master and zone.slave. Ideally, these should also be renamed to primary and secondary, but I can imagine that it would break scripts that parse the output.

Perhaps the stats could print zone.primary and zone.secondary in addition to the old names, so that scripts expecting the old names can continue to work.

I suggest the complete discontinuation of the master/slave terminology in a major update of NSD, such as version 5.

@wcawijngaards
Copy link
Member

Thanks for the heads up. The fix committed changes that. It prints zone.primary and zone.secondary in addition to the old names. And documents that in the nsd-control man page. Also some other log outputs are updated and sample config and the contrib nsd munin script that uses the primary and secondary zone counts for display.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants