Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ThreadAgnostic from AssemblyVersionLayoutRenderer when ASP.NET #634

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Feb 16, 2021

Trying to fix bug #633 on ASP.NET that was introduced with #305 (But not made better by #326)

Special hack implemented, since class-attributes are inherited and cannot be removed again.

Added unit-test to prove the fix is working.

@codecov-io
Copy link

Codecov Report

Merging #634 (b00ff5e) into master (1620a84) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@      Coverage Diff      @@
##   master   #634   +/-   ##
=============================
=============================

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1620a84...dd9b38c. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.9% 92.9% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASP.NET 4 ASP.NET MVC Classic bug size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants