Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aspnet-request-querystring - QueryStringKeys is required. #93

Closed
sgutkin opened this issue Feb 3, 2017 · 2 comments · Fixed by #98
Closed

aspnet-request-querystring - QueryStringKeys is required. #93

sgutkin opened this issue Feb 3, 2017 · 2 comments · Fixed by #98
Milestone

Comments

@sgutkin
Copy link

sgutkin commented Feb 3, 2017

Environment:

.net 4.6.2

This line works:
${aspnet-request-querystring:QueryStringKeys=someKey;OutputFormat=Flat}

This line does not work:
${aspnet-request-querystring:OutputFormat=Flat}

The documentation uses "CAN" instead of "MUST" this implies that the "QueryStringKeys is optional. Ideally this value would not be manadatory, but if it is mandatory then the documentation should reflect that it is.

Link to documentation : https://github.com/NLog/NLog/wiki/AspNetRequest-QueryString-Layout-Renderer

@304NotModified
Copy link
Member

Agree, we should change this.

@304NotModified
Copy link
Member

Fixed in 4.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants