LoggingConfiguration - ValidateConfig should only throw when enabled #4102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
MissingRequiredParameterShouldNotThrow
branch
6 times, most recently
from
40f8393 to
0ff1b5b
Compare
snakefoot
force-pushed
the
MissingRequiredParameterShouldNotThrow
branch
from
0ff1b5b to
94de02a
Compare
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to resolve #4099
For some reason then NLog has always thrown exceptions on missing / invalid required-parameters. Independent of throwException or throwConfigException.
I think NLog should continue even if having loaded invalid config (Logging should not break the host application).
Have adjusted the validation logic so it is expected that objects that implements
ISupportsInitializewill implicit callCheckRequiredParameters. This ensures that Target-objects will become disabled and not callInitializeTarget(Just like now).This has the side-effect that Layouts and LayoutRenderers will now also call
CheckRequiredParameterswhen created and used outside the context of theLoggingConfiguration. Think this is an improvement.