Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check with mypy in the CI #178

Closed
alecandido opened this issue Dec 9, 2022 · 0 comments · Fixed by #291
Closed

Check with mypy in the CI #178

alecandido opened this issue Dec 9, 2022 · 0 comments · Fixed by #291
Labels
benchmarks Benchmark (or infrastructure) related

Comments

@alecandido
Copy link
Member

Since I'm transitioning code to type hints (or type hints friendly, at least), we can get more from type checks.
In any case, types are inferred, so there is a benefit in type checking also without any type hint.

I propose to add mypy check to our usual CI workflow. In the end, it costs nothing, and it is not even an extra dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks Benchmark (or infrastructure) related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants