Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pids from operator runcard #183

Closed
alecandido opened this issue Dec 16, 2022 · 2 comments
Closed

Remove pids from operator runcard #183

alecandido opened this issue Dec 16, 2022 · 2 comments
Labels
output Output format and management refactor Refactor code

Comments

@alecandido
Copy link
Member

Ok, might be weird, but it is not wrong. This is a problem with the runcard: if you do not want pids to be in the OperatorCard, please open a separate PR based on this one.
I would say that it should be easier to fix, but it might propagate in a few places. Since it is weird but not completely wrong (most of the time you just use the example one, that has the correct basis), then I'd rather not consider blocking for this PR.

Can you open the further PR yourself? @felixhekhorn

Originally posted by @alecandido in #172 (comment)

@felixhekhorn felixhekhorn added refactor Refactor code output Output format and management labels Dec 19, 2022
@felixhekhorn
Copy link
Contributor

This is already solved in master, no?

def pids(self):

_operator = dict(

@alecandido
Copy link
Member Author

Yes, it seems like I forgot to link to the PR, and forgot to close after merging :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
output Output format and management refactor Refactor code
Projects
None yet
Development

No branches or pull requests

2 participants