Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIs fail because of a new version of scipy #2117

Closed
Radonirinaunimi opened this issue Jun 25, 2024 · 2 comments · Fixed by #2119
Closed

CIs fail because of a new version of scipy #2117

Radonirinaunimi opened this issue Jun 25, 2024 · 2 comments · Fixed by #2119
Assignees
@felixhekhorn @giacomomagni @RoyStegeman
Labels
bug Something isn't working

Comments

@Radonirinaunimi
Copy link
Member

Radonirinaunimi commented Jun 25, 2024 •
edited by RoyStegeman
Loading

From v1.14.0, the simps method from scipy.integrate has been removed, causing all the CIs to fail. The packages that depend on scipy are eko and hyperopt, and both of them do not impose a cap on which version should be installed.

Also the arc_lengths function in vp uses simps.
@Radonirinaunimi Radonirinaunimi added the bug Something isn't working label Jun 25, 2024
@RoyStegeman RoyStegeman mentioned this issue Jun 26, 2024
Merged
@felixhekhorn
Copy link
Contributor

As eko does not use this function, I don't think eko needs to react, right? #2119 should be a valid fix (PS: the relevant link is this 🙃)

@RoyStegeman
Copy link
Member

eko does not use this function

And neither does hyperopt, so indeed #2119 closes this

@RoyStegeman RoyStegeman linked a pull request Jun 26, 2024 that will close this issue
replace scipy.integrate.simps which has been removed in favor of simpson #2119
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felixhekhorn felixhekhorn

@giacomomagni giacomomagni

@RoyStegeman RoyStegeman

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace scipy.integrate.simps which has been removed in favor of simpson NNPDF/nnpdf
4 participants
@felixhekhorn @giacomomagni @Radonirinaunimi @RoyStegeman