Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add realistic test case for convolute_eko #122

Closed
felixhekhorn opened this issue Mar 2, 2022 · 2 comments · Fixed by #184
Closed

Add realistic test case for convolute_eko #122

felixhekhorn opened this issue Mar 2, 2022 · 2 comments · Fixed by #184
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@felixhekhorn
Copy link
Contributor

in order to not rely on a manual test (e.g. in pineko) we should add a proper test here, for that we need:

  • a simple grid G: this can be a positivity-like grid with, e.g., O1 = [u(x=0.1, Q2=100)] with a sufficent, but not too big number of bins in x
  • an EKO E: the "raw" eko should be sufficient to keep the actual library out of the game, say E(10 <- 100)
  • a PDF set f: to make the grids/table collapse to numbers

the actual check would then be f(Q0) x (E x G) = f(Q)

this could also be reused for #108

PS: corresponding email thread around Wed, Mar 02, 2022 at 11:27:26AM +0100

@cschwan cschwan added this to the v0.6.0 milestone Mar 2, 2022
@cschwan cschwan added the enhancement New feature or request label Mar 2, 2022
@cschwan cschwan self-assigned this Mar 2, 2022
@cschwan cschwan modified the milestones: v0.6.0, v0.5.2 Mar 4, 2022
@cschwan cschwan modified the milestones: v0.5.2, v0.5.3 Mar 29, 2022
@cschwan cschwan modified the milestones: v0.5.3, v0.5.4 Jun 22, 2022
@cschwan cschwan modified the milestones: v0.5.4, v0.5.5 Jul 8, 2022
@cschwan cschwan modified the milestones: v0.5.5, v.0.5.6 Aug 25, 2022
@cschwan
Copy link
Contributor

cschwan commented Sep 29, 2022

@andreab1997 @alecandido @felixhekhorn I'm now working on this and using NNPDF/pineko#62 as a test case. By the way, the crate ndarray_npy is very handy to load the EKO.

@alecandido
Copy link
Member

By the way, the crate ndarray_npy is very handy to load the EKO.

Good to know, it is one of those we considered for the Rust loader NNPDF/eko#97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants