Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATLAS_DY_7TEV_CC grid has wrong bin boundaries #20

Closed
cschwan opened this issue May 31, 2021 · 2 comments
Closed

ATLAS_DY_7TEV_CC grid has wrong bin boundaries #20

cschwan opened this issue May 31, 2021 · 2 comments
Assignees

Comments

@cschwan
Copy link
Contributor

cschwan commented May 31, 2021

There was a bug in PineAPPL which caused the bin limits for the first bin in a new slice to be wrong. This is fixed in NNPDF/pineappl@e5c9f5d. This concerns the ATLAS_DY_7TEV_CC grid first added in #18, where the plots are wrong.

Before:

bin   Mll     yll    dsig/dyll   neg unc pos unc
---+---+---+---+---+------------+-------+-------
  0  46  66   0 0.4  3.4984797e0  -4.46%   4.84%
  1  46  66 0.4 0.8  3.4921274e0  -4.47%   4.83%
  2  46  66 0.8 1.2  3.4752398e0  -4.47%   4.80%
  3  46  66 1.2 1.6  3.4583159e0  -4.48%   4.74%
  4  46  66 1.6   2  3.1409491e0  -4.99%   4.35%
  5  46  66   2 2.4  1.6327689e0  -5.80%   3.83%
  6  66 116   0 0.4  6.3528629e1  -2.92%   1.89%
  7  66 116 0.2 0.4  1.2675058e2  -2.92%   1.90%
  8  66 116 0.4 0.6  1.2612848e2  -2.93%   1.91%
  9  66 116 0.6 0.8  1.2524485e2  -2.94%   1.93%
 10  66 116 0.8   1  1.2405014e2  -2.95%   1.96%
 11  66 116   1 1.2  1.2238704e2  -3.06%   2.08%
 12  66 116 1.2 1.4  1.1479414e2  -3.18%   2.21%
 13  66 116 1.4 1.6  1.0168676e2  -3.23%   2.27%
 14  66 116 1.6 1.8  8.4886625e1  -3.26%   2.31%
 15  66 116 1.8   2  6.4877600e1  -3.28%   2.36%
 16  66 116   2 2.2  4.3057041e1  -3.28%   2.39%
 17  66 116 2.2 2.4  2.0836619e1  -3.28%   2.43%
 18 116 150   0 0.2  2.7150967e0  -1.84%   1.46%
 19 116 150 0.4 0.8  1.3459144e0  -1.86%   1.48%
 20 116 150 0.8 1.2  1.2696905e0  -1.94%   1.54%
 21 116 150 1.2 1.6  1.0626063e0  -1.97%   1.68%
 22 116 150 1.6   2 7.2346956e-1  -1.98%   1.85%
 23 116 150   2 2.4 2.9813687e-1  -1.99%   1.96%

Here the boundaries of bin 6 and 18 are obviously wrong.

After:

bin   Mll     yll    dsig/dyll   neg unc pos unc
---+---+---+---+---+------------+-------+-------
  0  46  66   0 0.4  3.4984797e0  -4.46%   4.84%
  1  46  66 0.4 0.8  3.4921274e0  -4.47%   4.83%
  2  46  66 0.8 1.2  3.4752398e0  -4.47%   4.80%
  3  46  66 1.2 1.6  3.4583159e0  -4.48%   4.74%
  4  46  66 1.6   2  3.1409491e0  -4.99%   4.35%
  5  46  66   2 2.4  1.6327689e0  -5.80%   3.83%
  6  66 116   0 0.2  1.2705726e2  -2.92%   1.89%
  7  66 116 0.2 0.4  1.2675058e2  -2.92%   1.90%
  8  66 116 0.4 0.6  1.2612848e2  -2.93%   1.91%
  9  66 116 0.6 0.8  1.2524485e2  -2.94%   1.93%
 10  66 116 0.8   1  1.2405014e2  -2.95%   1.96%
 11  66 116   1 1.2  1.2238704e2  -3.06%   2.08%
 12  66 116 1.2 1.4  1.1479414e2  -3.18%   2.21%
 13  66 116 1.4 1.6  1.0168676e2  -3.23%   2.27%
 14  66 116 1.6 1.8  8.4886625e1  -3.26%   2.31%
 15  66 116 1.8   2  6.4877600e1  -3.28%   2.36%
 16  66 116   2 2.2  4.3057041e1  -3.28%   2.39%
 17  66 116 2.2 2.4  2.0836619e1  -3.28%   2.43%
 18 116 150   0 0.4  1.3575483e0  -1.84%   1.46%
 19 116 150 0.4 0.8  1.3459144e0  -1.86%   1.48%
 20 116 150 0.8 1.2  1.2696905e0  -1.94%   1.54%
 21 116 150 1.2 1.6  1.0626063e0  -1.97%   1.68%
 22 116 150 1.6   2 7.2346956e-1  -1.98%   1.85%
 23 116 150   2 2.4 2.9813687e-1  -1.99%   1.96%
@cschwan cschwan self-assigned this May 31, 2021
@cschwan
Copy link
Contributor Author

cschwan commented May 31, 2021

Commit a1a1c84 fixes the problem.

@cschwan
Copy link
Contributor Author

cschwan commented May 31, 2021

Updated plots (46 < Mll < 66):

output-0

66 < Mll < 116:

output-1

116 < Mll < 150:

output-2

@cschwan cschwan closed this as completed May 31, 2021
This was referenced May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant