Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dilog implementation #128

Open
felixhekhorn opened this issue Jan 7, 2022 · 1 comment
Open

Dilog implementation #128

felixhekhorn opened this issue Jan 7, 2022 · 1 comment
Labels
math formulas, theorems & co. refactor Refactor code

Comments

@felixhekhorn
Copy link
Contributor

Do we want to swap the Dilog implementation here
https://github.com/N3PDF/yadism/blob/593a012dc7f4666c2c993dbdd37a6a2d55db0455/src/yadism/coefficient_functions/special/__init__.py#L8

with this one https://arxiv.org/abs/2201.01678 ?

@felixhekhorn felixhekhorn added refactor Refactor code math formulas, theorems & co. labels Jan 7, 2022
@alecandido
Copy link
Member

From the point of view of the code, they're both a bit ugly, but not terribly ugly.

For me, they're pretty the same, and it takes little to replace. If you wish, do it immediately, and run whatever benchmark (even a realistic one, but the easiest possible), to check that it's not worse (better/equal it's fine, even with equal performance we can replace).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
math formulas, theorems & co. refactor Refactor code
Projects
None yet
Development

No branches or pull requests

2 participants