-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify CDEPS gfs, cfsr, and gefs datm datamodes + Improve error checking in rt.sh (2388) + Add ability to read increment files on native cubed sphere grid (2304) #2389
Merged
zach1221
merged 71 commits into
ufs-community:develop
from
NickSzapiro-NOAA:simplify_datm
Aug 27, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In /github/workspace/tests/rt_utils.sh line 130: local test_status='PASS' ^---------^ SC2034 (warning): test_status appears unused. Verify use (or export if used externally).
zach1221
added
jenkins-ort
run ORT testing
hera-RT
Run Hera regression testing
gaea-RT
and removed
jenkins-ort
run ORT testing
hera-RT
Run Hera regression testing
gaea-RT
labels
Aug 26, 2024
on-behalf-of @ufs-community <ecc.platform@noaa.gov>
on-behalf-of @ufs-community <ecc.platform@noaa.gov>
on-behalf-of @ufs-community <ecc.platform@noaa.gov>
Testing is complete. We can start the merging process with cubed-sphere #342 |
@NickSzapiro-NOAA Please update .gitmodule urls and hashes. |
zach1221
requested review from
jkbk2004,
BrianCurtis-NOAA and
FernandoAndrade-NOAA
August 27, 2024 14:53
jkbk2004
approved these changes
Aug 27, 2024
BrianCurtis-NOAA
approved these changes
Aug 27, 2024
14 tasks
DavidHuber-NOAA
added a commit
to DavidHuber-NOAA/ufs-weather-model
that referenced
this pull request
Sep 9, 2024
…r-model into develop * 'develop' of https://github.com/ufs-community/ufs-weather-model: update mom6 to its main repo. 20240824 commit (FMA) (ufs-community#2412) Update CMEPS; fix aux history functionality for float variable type; Switch to using Aux history files in atm_ds2s_docn_dice test; Remove IFI tests (was ufs-community#2417) (ufs-community#2395) Combination for CCPP-physics ufs-community#213 and ufs-community#218 (H2O scheme refactor and C3/SAS/MYNN fix) (ufs-community#2408) Unify CDEPS gfs, cfsr, and gefs datm datamodes + Improve error checking in rt.sh (2388) + Add ability to read increment files on native cubed sphere grid (2304) (ufs-community#2389) sync with head of NOAA-EMC UPP develop (ufs-community#2326) Allow use of downscaled warmstart files for cpld_control_sfs test (ufs-community#2375) update to MOM6 main 20240729 commit (gfdl-to-main-2024-05-31) (ufs-community#2381)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
No Baseline Change
No Baseline Change
Ready for Commit Queue
The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Queue Requirements:
Description:
Code for gfs, cfsr, and gefs datm datamodes is very similar (just with different function names). This PR removes the duplicates. As gefs datm datamode is already in ESCOMP/CDEPS, gefs is retained here. Note that GFS, GEFS, CFSR, etc. input datasets are still handled via streams in the same way, just with datamode == 'GEFS'. Sunset gfs_hafs datamode no longer used.
These PRs have also been merged for commit queue (via PR to this branch on their behalf):
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: