Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/subseasonal METplus rc1 changes #621

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from

Conversation

ShannonShields-NOAA
Copy link
Contributor

Note to developers: You must use this PR template!

Description of Changes

Please include a summary of the changes and the related GitHub issue(s). Please also include relevant motivation and context.
The following is addressed in this PR:
-Adjusts/adds MET MPR columns in grid-to-obs avg and anomaly scripts so that they can be read into METplus/match beta5 output (no changes needed for G2G as agreed upon in 12/19 meeting)
-Lydia's email replaced Alicia's in MAILTO for sending missing file emails (no testing needed)
-ecf/scripts/plots/subseasonal were fixed to match current dev/drivers (ncpus/nproc settings, naming conventions, etc.)
-ecf/defs/evs-nco.def task names were fixed to match current development (i.e. "anom" to "temp")

Developer Questions and Checklist

  • Is this a high priorty PR? If so, why and is there a date it needs to be merged by?
  • No
  • Do you have any planned upcoming annual leave/PTO?
  • Yes, 12/27
  • Are there any changes needed for when the jobs are supposed to run?
    No
  • The code changes follow NCO's EE2 Standards.
  • Developer's name is removed throughout the code and have used ${USER} where necessary throughout the code.
  • References the feature branch for HOMEevs are removed from the code.
  • J-Job environment variables, COMIN and COMOUT directories, and output follow what has been defined for EVS.
  • Jobs over 15 minutes in runtime have restart capability.
  • If applicable, changes in the dev/drivers/scripts or dev/modulefiles have been made in the corresponding ecf/scripts and ecf/defs/evs-nco.def?
  • Jobs contain the approriate file checking and don't run METplus for any missing data.
  • Code is using METplus wrappers structure and not calling MET executables directly.
  • Log is free of any ERRORs or WARNINGs.

Testing Instructions

Please include testing instructions for the PR assignee. Include all relevant input datasets needed to run the tests.
After checking out this feature branch, make sure to set HOMEevs and FIXevs accordingly. Set COMIN to EMC parallel prep path in dev/drivers/scripts/stats/subseasonal scripts.
Please run the following to test the G2O stats changes:
dev/drivers/scripts/stats/subseasonal/jevs_subseasonal_cfs_grid2obs_stats.sh
jevs_subseasonal_gefs_grid2obs_stats.sh
*NOTE: run.ver was changed to use MET and METplus rc1 versions so this change will be merged for the entire develop branch.
Also please double-check the ecf script changes (listed on the Fixes doc).

@malloryprow malloryprow self-assigned this Dec 19, 2024
@malloryprow malloryprow added this to the EVS v2.0.0 milestone Dec 19, 2024
@malloryprow malloryprow added the enhancement New feature or request label Dec 19, 2024
@malloryprow
Copy link
Contributor

Thanks for getting this PR in @ShannonShields-NOAA! The parallel is going to switch to using rc1 after the holidays, so I probably will not merge it into develop until after the switch happens. We can still test this though in the meantime so it is ready to go once that switch happens.

@ShannonShields-NOAA
Copy link
Contributor Author

Sounds good! WCOSS2 is supposed to come back tomorrow, but we shall see about that. Otherwise, hopefully we can test sometime next week if possible.

Copy link
Contributor

@AliciaBentley-NOAA AliciaBentley-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this PR and think that the changes in it look good! They are consistent with the changes listed in the PR submission. I approve this PR to be merged once WCOSS2 comes back to developers and the PR is tested. Thanks!

CC @malloryprow @ShannonShields-NOAA

@malloryprow
Copy link
Contributor

COMOUT is /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr621/evs/v2.0/stats/subseasonal.

1. jevs_subseasonal_cfs_grid2grid_stats

Log File: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr621/EVS/dev/drivers/scripts/stats/subseasonal/jevs_subseasonal_cfs_grid2obs_stats.o280744
DATA: /lfs/h2/emc/stmp/mallory.row/evs_test/prod/tmp/jevs_subseasonal_cfs_grid2obs_stats.280744.dbqs01

2. jevs_subseasonal_gefs_grid2grid_stats

Log File: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr621/EVS/dev/drivers/scripts/stats/subseasonal/jevs_subseasonal_gefs_grid2obs_stats.o280745
DATA: /lfs/h2/emc/stmp/mallory.row/evs_test/prod/tmp/jevs_subseasonal_gefs_grid2obs_stats.280745.dbqs01

@ShannonShields-NOAA
Copy link
Contributor Author

@malloryprow I have reviewed the output and everything looks correct (no WARNINGs or ERRORs and the G2O stat values match those of the current beta5 EMC parallel). Once the holidays are over and the parallel switches to rc1, this PR should be set to merge.

Copy link
Contributor

@malloryprow malloryprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good and testing successful.

Thanks @ShannonShields-NOAA!

@malloryprow
Copy link
Contributor

I'm going to hold off on merging until we switch to rc1 in the parallel. I don't want to merge into develop (and para) until then. The plan is to do the switch after the holidays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants