Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in parm/atm/obs/config/satwind_goes-17.yaml #742

Closed
RussTreadon-NOAA opened this issue Nov 17, 2023 · 3 comments
Closed

Typo in parm/atm/obs/config/satwind_goes-17.yaml #742

RussTreadon-NOAA opened this issue Nov 17, 2023 · 3 comments
Assignees

Comments

@RussTreadon-NOAA
Copy link
Contributor

differs from

The order in satwind_goes-17.yaml is reversed compared to satwind_goes-16.yaml. The order in satwind_goes-16.yaml is correct.

This issue is opened to document the typo and its correction. The correction can be committed to feature/gdas-validation-satwind

@RussTreadon-NOAA
Copy link
Contributor Author

@emilyhcliu , a test of the fix is described in JEDI-T2O issue #98.

Would you like me to make the fix in feature/gdas-validation-satwind, open a PR, and list you as a reviewer?

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Nov 17, 2023
@RussTreadon-NOAA
Copy link
Contributor Author

RussTreadon-NOAA commented Nov 17, 2023

The following has been done in a working copy of feature/gdas-validation-satwind on Orion

  1. merge feature/gdas-validation into feature/gdas-validation-satwind
  2. correct typo in parm/atm/obs/config/satwind_goes-17.yaml

Given your green light, @emilyhcliu , I'll push the updated branch to NOAA-EMC/GDASApp, open a PR, and ask you to review.

@CoryMartin-NOAA
Copy link
Contributor

@RussTreadon-NOAA sorry I saw you also created a branch, whoops! I didn't intend to reproduce work (but it was a quick fix) I think this can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants