Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for cycling soil analysis experiments #593

Closed
ClaraDraper-NOAA opened this issue Jul 25, 2023 · 8 comments · Fixed by #675
Closed

Fixes for cycling soil analysis experiments #593

ClaraDraper-NOAA opened this issue Jul 25, 2023 · 8 comments · Fixed by #675
Assignees

Comments

@ClaraDraper-NOAA
Copy link
Contributor

A number is fixes are required to run cycling experiments with the new EnKF soil analysis:

  1. The soil moisture and temperature increments are added outside the GSI code (in UFS_UTILS). This means that the soil DA increments must always be written out, regardless of whether the increment or analysis is requested for the atmosphere.

  2. The enkf reads in the background states in gridio_gfs.f90. The variable names for the soil states need to be updated from slc[1234] to soill[1234] and stc[1234] to soilt[1234].

  3. soil temperature (STC) is defined over the ocean (and holds some sort of ocean temp). soil moisture (SLC) is defined, and given a value of 1 over the ocean. The discontinuities in ensemble spread at the coast between STC/SLC-ocean and STC/SLC-land induce extreme values in the output of the ensemble smoothing routine (which can then crash the model, due to the extreme soil temperature gradients created). We may wish to develop a smoothing solution for land variables in the future, but for now the immediate solution is to not apply the smoothing to soil variables.

@ClaraDraper-NOAA
Copy link
Contributor Author

@CoryMartin-NOAA 2 of 2 issues I need to merge before you can start soil analysis experiments.

@CoryMartin-NOAA
Copy link
Contributor

@ClaraDraper-NOAA are these already done and just need merged in through PRs or is there development work that still needs to be done?

@ClaraDraper-NOAA
Copy link
Contributor Author

I've already done them, and just need to merge them in.

@ClaraDraper-NOAA
Copy link
Contributor Author

... will get to in this week, hopefully.

@CoryMartin-NOAA
Copy link
Contributor

Got it, let me know how I can help

@RussTreadon-NOAA
Copy link
Contributor

@ClaraDraper-NOAA , the GSI Handling Review team is working through GSI issues to see which, if any, may be closed. May this issue be closed?

@ClaraDraper-NOAA
Copy link
Contributor Author

@RussTreadon-NOAA No, I still need to submit these fixes I'm afraid. I'll make sure to do it by the end of the year.

@RussTreadon-NOAA
Copy link
Contributor

Thank you @ClaraDraper-NOAA for your reply. We'll keep this issue open until the changes are merged into develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants