Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate GMAO conventional obs YAMLs #60

Open
ADCollard opened this issue Feb 22, 2023 · 13 comments
Open

Evaluate GMAO conventional obs YAMLs #60

ADCollard opened this issue Feb 22, 2023 · 13 comments
Assignees

Comments

@ADCollard
Copy link

Evaluate the GMAO conventional data YAMLs in the context of the GDASApp.

@ADCollard
Copy link
Author

GMAO have shared one of their YAMLs for aircraft. This does not include the bias correction, so we can work on adding that.

@ADCollard
Copy link
Author

ADCollard commented Apr 20, 2023

Looking at the aircraft YAML from GMAO.

There are some additional filters required that are not available in UFO develop.

ObsErrorFactorDuplicateCheck
ObsErrorFactorPressureCheck

There is also a weird error

Test "ufo/ObsFilters/testFilters" failed with unhandled eckit::Exception: Bad Conversion: 
Cannot convert (1.4,1.4,1.4,1.4,1.4,1.4) (List) to double @ 
 (/scratch1/NCEPDEV/global/spack-stack/spack-stack-v1/cache/build_stage/emc.nemspara/spack-stage-eckit-1.20.2-cxvre73ysjwofwoqpbwssnsqeucjlg2h/spack-src/src/eckit/value/Content.cc +75 badConversion)

Without the new filters testing will be limited, but we can look at aircraft bias correction and humidity QC (which is not included by GMAO).

@ADCollard
Copy link
Author

ADCollard commented May 10, 2023

Finally got the system working. Air temperature shows significant differences as would be expected from not having bias correction in place:
hofxdiff_histogram_diag_aircraft_2021080100_Aircraft_airTemperature
Final ob errors are fairly close but differ too:
errordiff_histogram_diag_aircraft_2021080100_Aircraft_airTemperature

@ADCollard
Copy link
Author

Humidity QC is not included in the GMAO YAMLs.
H(x) differences are at the 1.e-8 level:
hofxdiff_histogram_diag_aircraft_2021080100_Aircraft_specificHumidity

Something is wrong with the obs error differences:
errordiff_histogram_diag_aircraft_2021080100_Aircraft_specificHumidity

@ADCollard
Copy link
Author

Wind H(x) differences are very small (as expected):
hofxdiff_histogram_diag_aircraft_2021080100_Aircraft_windNorthward
hofxdiff_histogram_diag_aircraft_2021080100_Aircraft_windEastward
The obs error differences are very large, however. We certainly need to dig.
errordiff_histogram_diag_aircraft_2021080100_Aircraft_windNorthward
errordiff_histogram_diag_aircraft_2021080100_Aircraft_windEastward

@ADCollard
Copy link
Author

Re-starting this work with updated GMAO YAML files

Test YAMLs are in https://github.com/NOAA-EMC/GDASApp/tree/feature/gmao_eval/parm/atm/obs/testing/swell

@ADCollard
Copy link
Author

ADCollard commented Oct 11, 2023

Differences for sondes

  • HofX is very close. ~1.e-9 for spec humidity and 1.e-5K for temperature.
  • Some weird plots for errors. Need to dig further.

hofxdiff_histogram_diag_sondes_2021080100_Radiosondes_windNorthward
hofxdiff_histogram_diag_sondes_2021080100_Radiosondes_windEastward
hofxdiff_histogram_diag_sondes_2021080100_Radiosondes_stationPressure
hofxdiff_histogram_diag_sondes_2021080100_Radiosondes_specificHumidity
hofxdiff_histogram_diag_sondes_2021080100_Radiosondes_airTemperature
errordiff_histogram_diag_sondes_2021080100_Radiosondes_windNorthward
errordiff_histogram_diag_sondes_2021080100_Radiosondes_windEastward
errordiff_histogram_diag_sondes_2021080100_Radiosondes_stationPressure
errordiff_histogram_diag_sondes_2021080100_Radiosondes_specificHumidity
errordiff_histogram_diag_sondes_2021080100_Radiosondes_airTemperature

@PraveenKumar-NOAA
Copy link

@ADCollard thanks for the plots. After comment out a few filter lines in sondes yaml, I was able to run the test and my results are very similar to your results except one for the stationPressure obs error plot:

errordiff_histogram_sondes_diag_2021080100_sondes_stationPressure

@ADCollard
Copy link
Author

@PraveenKumar-NOAA I am glad you are looking at it. Take a look at my YAML here. It runs without needing to delete any filters.

@PraveenKumar-NOAA
Copy link

@ADCollard thanks. I will look into this.

@PraveenKumar-NOAA
Copy link

PraveenKumar-NOAA commented Oct 11, 2023

@ADCollard I noticed an additional line 'pressure: MetaData/pressure' at few places in your yaml, it worked now without any comment and I produced exactly your results.

@PraveenKumar-NOAA
Copy link

PraveenKumar-NOAA commented Oct 12, 2023

@ADCollard after making the following minor changes in your yaml:

  1. uncomment line 34
  2. uncomment line 35 and replace surface_geopotential_height by surface_geometric_height
  3. line 135: replace surface_altitude by surface_geometric_height

I got the following results for the stationPressure:

errordiff_histogram_sondes_diag_2021080100_sondes_stationPressure (1)

gsi_hofx_vs_jedi_hofx_sondes_diag_2021080100_sondes_stationPressure

If we use the GSI da_psfc_scheme instead of UKMO, the results are very similar:

errordiff_histogram_sondes_diag_2021080100_sondes_stationPressure (2)

gsi_hofx_vs_jedi_hofx_sondes_diag_2021080100_sondes_stationPressure (1)

@ADCollard
Copy link
Author

Splitting this YAML into one for sondes and one for aircraft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants