Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove VERBOSE code in bacio.c #83

Closed
edwardhartnett opened this issue Oct 12, 2021 · 0 comments · Fixed by #84
Closed

Remove VERBOSE code in bacio.c #83

edwardhartnett opened this issue Oct 12, 2021 · 0 comments · Fixed by #84
Assignees
Labels
enhancement New feature or request

Comments

@edwardhartnett
Copy link
Contributor

bacio.c has some code like this:

    /* Check for illegal combinations of options */
    if (( BAOPEN_RONLY & *mode) &&
        ( (BAOPEN_WONLY & *mode) || (BAOPEN_WONLY_TRUNC & *mode) || (BAOPEN_WONLY_APPEND & *mode) ) ) {
#ifdef VERBOSE
        printf("illegal -- trying to open both read only and write only\n");
#endif
        return 255;
    }

Note the VERBOSE pre-processor. It is never set so the verbose code is never run.

These kind of verbose statements are not that helpful, and are not available to the end user. They should be removed to unclutter the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant