Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make intel build required to pass CI #88

Closed
edwardhartnett opened this issue Oct 13, 2021 · 0 comments
Closed

Make intel build required to pass CI #88

edwardhartnett opened this issue Oct 13, 2021 · 0 comments
Assignees
Labels
test Testing is important!

Comments

@edwardhartnett
Copy link
Contributor

This was a bit tricky. We had an intel build, but it was not marked as "required" to pass by GitHub, and we need it to be.

But when I tried to add it to the list of required builds, it did not appear in the dropdown list.

Turns out, we need to use different names for our builds in different workflows. For example, here's a section from our main workflow, with GNU:

jobs:
  build:
    runs-on: ubuntu-20.04

This is called "build" by the CI system. By reusing the same code in the Intel workflow file, it got the same name, "build". Then I changed the intel one to intel_build:

jobs:
  intel_build:
    runs-on: ubuntu-latest

Now "intel_build" appears on the GitHub dropdown list of available builds, and I can require that it pass before PRs are merged.

@kgerheiser you may wish to take note of this peculiarity...

@edwardhartnett edwardhartnett added the test Testing is important! label Oct 13, 2021
@edwardhartnett edwardhartnett self-assigned this Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Testing is important!
Projects
None yet
Development

No branches or pull requests

1 participant