Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require g2c during build, remove duplicate C code for compression from g2, use g2c directly #705

Closed
edwardhartnett opened this issue May 30, 2024 · 1 comment · Fixed by #753
Assignees
Labels
build Building software can be complicated

Comments

@edwardhartnett
Copy link
Contributor

Currently we have some C code copied from g2c in the g2 project: g2cjpeg2000.c and g2cpng.c.

These are both in the g2c library. We need to make the g2c library mandatory in the build, and use these functions from g2c, instead of having duplicate copies of the code.

We then need to add AEC to the g2 library, using it's implementation in the g2c library.

Also, whenever we call C, we need to make sure we are using the ISO standard C/Fortran API, not relying on the underscore trick, which is not standard.

@edwardhartnett
Copy link
Contributor Author

Does anyone have any code to check in for this?

I would like to reassign this to @AlysonStahl-NOAA who is now working on g2/g2c...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Building software can be complicated
Projects
Status: Done
2 participants